Removed UI buttons that seem, to me, detrimental to UX #66

Merged
merged 7 commits into from Nov 29, 2012

Conversation

Projects
None yet
3 participants
@chbrown
Contributor

chbrown commented May 24, 2012

No more span.extend, or hover: +opacity or hover: show changes. Better UX, in my opinion. Less clicks, less squinting, less trouble with nested scrolling (also removed the max-height:s).

@chbrown

This comment has been minimized.

Show comment Hide comment
@chbrown

chbrown Aug 11, 2012

Contributor

Hi Chris McDonough, is that a no?

Contributor

chbrown commented Aug 11, 2012

Hi Chris McDonough, is that a no?

@mcdonc

This comment has been minimized.

Show comment Hide comment
@mcdonc

mcdonc Aug 11, 2012

Owner

I'm fourteen promises behind on software maintenance right now, sorry. Maybe someone else can evaluate this and decide whether it makes sense, and so forth sooner than I will be able to.

Owner

mcdonc commented Aug 11, 2012

I'm fourteen promises behind on software maintenance right now, sorry. Maybe someone else can evaluate this and decide whether it makes sense, and so forth sooner than I will be able to.

@blaflamme

This comment has been minimized.

Show comment Hide comment
@blaflamme

blaflamme Aug 11, 2012

Owner

I'm not sure what your fixes provide, running it and I'm just blind. Can you explain more?

Owner

blaflamme commented Aug 11, 2012

I'm not sure what your fixes provide, running it and I'm just blind. Can you explain more?

@chbrown

This comment has been minimized.

Show comment Hide comment
@chbrown

chbrown Aug 11, 2012

Contributor

Yes, basically there are three changes, which all apply to the interactive debugger UI:

  1. The prompt and little text file icons show all the time, instead of only when hovered over.
  2. The expression result boxes now resize to fit the contents, instead of having nested scrolling on the page (which is what you get if you set max-height or height and leave overflow: scroll as the default).
  3. When an expression result is long, there is no more ellipsis truncation. The chance of the information I need being in the first 200 or so characters of a very long result string is very low. Thus, I have it print the whole string.

And then a couple of the commits are changes so that I can pip install from the github repo, since setuptools usually uses subversion hints to tell what static files it needs, I need to specify explicitly what files are needed in the setup.py package_data dict.

Contributor

chbrown commented Aug 11, 2012

Yes, basically there are three changes, which all apply to the interactive debugger UI:

  1. The prompt and little text file icons show all the time, instead of only when hovered over.
  2. The expression result boxes now resize to fit the contents, instead of having nested scrolling on the page (which is what you get if you set max-height or height and leave overflow: scroll as the default).
  3. When an expression result is long, there is no more ellipsis truncation. The chance of the information I need being in the first 200 or so characters of a very long result string is very low. Thus, I have it print the whole string.

And then a couple of the commits are changes so that I can pip install from the github repo, since setuptools usually uses subversion hints to tell what static files it needs, I need to specify explicitly what files are needed in the setup.py package_data dict.

@blaflamme

This comment has been minimized.

Show comment Hide comment
@blaflamme

blaflamme Aug 11, 2012

Owner

Thanks, can you sign the contributor agreement and then add a summary of your changes in CHANGES.txt under Next release?

Owner

blaflamme commented Aug 11, 2012

Thanks, can you sign the contributor agreement and then add a summary of your changes in CHANGES.txt under Next release?

@chbrown

This comment has been minimized.

Show comment Hide comment
@chbrown

chbrown Aug 11, 2012

Contributor

Done. Thanks for your help with this!

Contributor

chbrown commented Aug 11, 2012

Done. Thanks for your help with this!

@chbrown

This comment has been minimized.

Show comment Hide comment
@chbrown

chbrown Oct 28, 2012

Contributor

Maybe this can get in for 1.0.4?

Contributor

chbrown commented Oct 28, 2012

Maybe this can get in for 1.0.4?

@blaflamme

This comment has been minimized.

Show comment Hide comment
@blaflamme

blaflamme Oct 28, 2012

Owner

Yes it'll make sure it's in the next version.

Owner

blaflamme commented Oct 28, 2012

Yes it'll make sure it's in the next version.

@blaflamme blaflamme merged commit 522eac8 into Pylons:master Nov 29, 2012

@blaflamme

This comment has been minimized.

Show comment Hide comment
@blaflamme

blaflamme Nov 29, 2012

Owner

Thanks!

Owner

blaflamme commented Nov 29, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment