Fix to handle non-ascii characters in platform version shown in Versions panel. #98

Merged
merged 1 commit into from Jun 24, 2013

Projects

None yet

4 participants

@hanula

Non-ascii characters in platform name, for example Fedora's <>
causes VersionDebugPanel to fail with UnicodeDecodeError. Added compat.text_(.., 'utf8')
convertion and moved platform name discovery to helper method to be easily swaped in unit tests.

@hanula hanula Handle non-ascii characters in platform version shown in Versions panel.
Non-ascii characters in platform name, for example Fedora's <<Schrödinger’s Cat>>
causes VersionDebugPanel to fail with UnicodeDecodeError. Added compat.text_(.., 'utf8')
convertion and moved platform name discovery to helper method to be easily swaped in unit tests.
0d00ca2
@tseaver
Pylons Project member

The patch looks pretty good. For future reference, please avoid mixing whitespace changes with substanntive ones: they make review trickier than necessary.

Can you please add a description of the change in 'CHANGES.txt'? Thank!

@brodul

All tests pass (with the 38cc717 patch).

I recommend to add the following line to CHANGES.txt while merging:

  • Fix platform name encoding.
@mcdonc mcdonc merged commit 0d00ca2 into Pylons:master Jun 24, 2013
@mcdonc
Pylons Project member

Thank you, it's merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment