Clarification of exclog.ignore documentation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@conradoplg the Python 3.2 failure is not due to this PR. I will be pushing another PR which removes 2.6 and 3.2 support, and adds 3.5 support. |
|
I have restarted the build after merging #28. |
|
Ugh, I guess I need to have you rebase your branch and re-push your branch. E.g.: $ cd /path/to/your/clone/of/pyramid_exclog
$ git remote add upstream https://github.com/Pylons/pyramid_exclog.git
$ git fetch upstream
$ git rebase upstream/master
$ git push -f origin ignore-clarification |
Changed exclog.ignore documentation to make clear it is possible to re-enable logging http exceptions.
|
@conradoplg Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed exclog.ignore documentation to make clear it is possible to re-enable logging http exceptions.