/pyramid_jinja2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python versions #146

Merged
merged 7 commits into from Jul 28, 2018

Conversation

Reviewers

@mmerickel mmerickel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stevepiercy @mmerickel
@stevepiercy
Member

stevepiercy commented Jul 28, 2018 •
edited

Bump Python and Pyramid versions to current supported ones
@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy

stevepiercy Jul 28, 2018

Member

See #143 (comment)
Member

stevepiercy commented Jul 28, 2018

See #143 (comment)

@stevepiercy stevepiercy merged commit 64214a4 into Pylons:master Jul 28, 2018
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stevepiercy stevepiercy deleted the stevepiercy:bump-python-versions branch Jul 28, 2018

@stevepiercy stevepiercy referenced this pull request Jul 28, 2018

Open

Adds support for mappings in gettext calls #143

setup.py
@@ -26,28 +26,26 @@
CHANGES = open(os.path.join(here, 'CHANGES.txt')).read()
requires = [
'Jinja2',

This comment has been minimized.

Show comment
Hide comment
@mmerickel

mmerickel Jul 28, 2018

Member

This should have preserved the >= 2.5.0 pin.
Copy link
@mmerickel

mmerickel Jul 28, 2018

Member

This should have preserved the >= 2.5.0 pin.
@mmerickel

This comment has been minimized.

Show comment
Hide comment
@mmerickel

mmerickel Jul 28, 2018

Member

This dropped testing on pyramid 1.3, and it should not have. This should not have been merged without review?
Member

mmerickel commented Jul 28, 2018

This dropped testing on pyramid 1.3, and it should not have. This should not have been merged without review?

@stevepiercy stevepiercy referenced this pull request Jul 28, 2018

Merged

Restore pin and testing versions #147

@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy

stevepiercy Jul 28, 2018

Member

@mmerickel sorry, I didn't know this mattered, and I had an IRC conversation with domenkozar about the things I thought mattered. See #147.
Member

stevepiercy commented Jul 28, 2018

@mmerickel sorry, I didn't know this mattered, and I had an IRC conversation with domenkozar about the things I thought mattered. See #147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment