fixed wrong asserts in section Unit tests #11

Merged
merged 1 commit into from Mar 8, 2012

Projects

None yet

3 participants

@AnneGilles

what was assertEqual should have been assertTrue

@mcdonc mcdonc merged commit 01d2fb2 into Pylons:master Mar 8, 2012
@mcdonc
Member
mcdonc commented Mar 8, 2012

thank you!

@pumazi
pumazi commented on 1860808 May 24, 2012

Looks like your forgot to change the == to , when you did the assertTrue to assertEqual conversion. These will result in an error if anyone tries them.

Member

I think you may have read the diff backwards, because the conversion was from assertEqual to assertTrue. I changed it back to using assertEqual instead of assertTrue, and inserted the comma anyway.

Ah, you're right, I did read it wrong. At any rate, the lines you changed here hadn't been pushed out to the docs published at http://packages.python.org/pyramid_mailer/#unit-tests. Sorry for the confusion, but thanks for changing it to assertEqual in your latest commit. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment