Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Another int overflow on waitress Buffers #47
So it's another case of #22, now on waitress 0.8.7
Org exception was:
I did two changes just to test out:
Then we end up with:
I did this test to mimic the issue on append():
But i have no idea how to reliable test the handle_write() and flush() issue.
@marcinkuzminski can you tell whether this error is raised in the situation that @tseaver suggested? He suggested it happens when a ReadOnlyFileBasedBuffer is added to self.outbufs at https://github.com/Pylons/waitress/blob/master/waitress/channel.py#L310 . It'd mean that you were using wsgi.file_wrapper to serve a file, is that true?
@mcdonc unfortunately i don't have access to this information (it's a machine of one of our clients)
This error doesn't occur when serving files, it's a clone operation of a huge (around 6GB) mercurial repository.
in th environ
The presence of 'wsgi.file_wrapper' in the environ doesn't really mean much; anyone who is using waitress will have this in the environ.
Your test demonstrates that the append method of an OverflowableBuffer should probably use
I've checked in these fixes but I'm not totally confident that my commit will fix all of the OverflowError cases; hopefully you can test the waitress master and let us know if you see any more of these in production.