Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
start_response() reraises exc_info even if headers have not been sent #51
While working on a wsgi error handler, I think I ran across a (small) bug in waitress' start_response function...
The following quick patch seems to fix things... (my apologies, I'm new to github, and can't for the life of me figure out how to make an attachment).
First up, thanks! I'm in work, so somebody else will likely deal with the meat of the issue, but I though I'd cover how submissions are usually handled through GitHub.
The typical way of submitting a change in GitHub is to fork the repository into your own profile, create a branch, make and test the change, and then issue a pull request. The pull request appears as an issue on the original repo's issue tracker, and, if everything's good, can be merged with the click of a button. The nice thing about it is that any changes make on the source branch with the changes submitted in the pull request will appear as part of the pull request subsequently, so if there are any issues, there's not need to perform any further edits.
I don't suppose you could knock together a quick test case to demonstrate the issue? If not, I'll see what I can do after work if nobody else has dealt with the issue.