Add fallback to numeric only nameinfo #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalresistor
force-pushed
the
bugfix/nameinfo
branch
from
a4e7cb1 to
7e9b3a7
Compare
digitalresistor
force-pushed
the
bugfix/nameinfo
branch
from
7e9b3a7 to
4bded8a
Compare
digitalresistor
added a commit
that referenced
this pull request
Feb 4, 2017
This was referenced Feb 4, 2017
This was referenced Feb 26, 2017
This was referenced Apr 18, 2017
This was referenced Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fallback so that if we get an exception on the first
getnameinfowe fall-back to calling it with full numeric support. This should always succeed, and return valid information.Closes #149