Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback to numeric only nameinfo #153

Merged
merged 2 commits into from Feb 3, 2017
Merged

Add fallback to numeric only nameinfo #153

merged 2 commits into from Feb 3, 2017

Conversation

@bertjwregeer
Copy link
Member

bertjwregeer commented Jan 17, 2017

This adds a fallback so that if we get an exception on the first getnameinfo we fall-back to calling it with full numeric support. This should always succeed, and return valid information.

Closes #149

@bertjwregeer bertjwregeer force-pushed the bugfix/nameinfo branch from 7e9b3a7 to 4bded8a Jan 17, 2017
@bertjwregeer bertjwregeer merged commit 094d1cd into master Feb 3, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bertjwregeer bertjwregeer deleted the bugfix/nameinfo branch Feb 3, 2017
bertjwregeer added a commit that referenced this pull request Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.