Fix issue #64 Uncaptured exception instead of 400 when receiving non-ascii bytes in request url #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I'm clueless about what the right thing to do is.
|
Could you make sure to read and sign CONTRIBUTORS.txt please? |
|
Sorry, I didn't notice that file. I've added my name now. May I suggest creating a |
|
We can't wait for this to be merged and made available :-) Thank you @Flimm ! |
|
Sorry, I must have missed this PR being updated in the long list of work related PR's. Will check later tonight and most likely cut a new release! |
|
No worries! Thank you very very much @bertjwregeer ! |
|
Thanks @Flimm! @gregsadetsky thanks for commenting on this! |
This was referenced Oct 11, 2017
This was referenced Oct 19, 2017
This was referenced Oct 30, 2017
This was referenced Nov 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the existing
fix.issue64branch, rebased it, and added a new commit. This is a fix for #64.This makes the new test pass in both Python 2 and 3. It doesn't matter that Python 2 doesn't raise a ParsingError, all that matters is that the connection isn't closed abruptly, and the test verifies that that remains the case for both Python 2 and Python 3.