Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #64 Uncaptured exception instead of 400 when receiving non-ascii bytes in request url #162

Merged
merged 3 commits into from Aug 16, 2017

Conversation

@Flimm
Copy link
Contributor

@Flimm Flimm commented Jun 1, 2017

I took the existing fix.issue64 branch, rebased it, and added a new commit. This is a fix for #64.

This makes the new test pass in both Python 2 and 3. It doesn't matter that Python 2 doesn't raise a ParsingError, all that matters is that the connection isn't closed abruptly, and the test verifies that that remains the case for both Python 2 and Python 3.

mcdonc and others added 2 commits Jul 14, 2014
…ueless about what the right thing to do is.
@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Jun 1, 2017

Could you make sure to read and sign CONTRIBUTORS.txt please?

@Flimm
Copy link
Contributor Author

@Flimm Flimm commented Jun 2, 2017

Sorry, I didn't notice that file. I've added my name now. May I suggest creating a CONTRIBUTING or CONTRIBUTING.md file that instructs users to do this? GitHub will prominently display it when filing an issues or creating a pull request.

@stevepiercy
Copy link
Member

@stevepiercy stevepiercy commented Jun 2, 2017

@Flimm good suggestion. I created an issue #163.

@gregsadetsky
Copy link

@gregsadetsky gregsadetsky commented Aug 9, 2017

We can't wait for this to be merged and made available :-) Thank you @Flimm !

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Aug 9, 2017

Sorry, I must have missed this PR being updated in the long list of work related PR's. Will check later tonight and most likely cut a new release!

@gregsadetsky
Copy link

@gregsadetsky gregsadetsky commented Aug 9, 2017

No worries! Thank you very very much @bertjwregeer !

@bertjwregeer bertjwregeer merged commit 87311e8 into Pylons:master Aug 16, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Aug 16, 2017

Thanks @Flimm!

@gregsadetsky thanks for commenting on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.