New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #64 Uncaptured exception instead of 400 when receiving non-ascii bytes in request url #162

Merged
merged 3 commits into from Aug 16, 2017

Conversation

Projects
None yet
5 participants
@Flimm
Contributor

Flimm commented Jun 1, 2017

I took the existing fix.issue64 branch, rebased it, and added a new commit. This is a fix for #64.

This makes the new test pass in both Python 2 and 3. It doesn't matter that Python 2 doesn't raise a ParsingError, all that matters is that the connection isn't closed abruptly, and the test verifies that that remains the case for both Python 2 and Python 3.

mcdonc and others added some commits Jul 14, 2014

This fixes #64 but only for Python 3; Python 2 fails the test. I'm cl…
…ueless about what the right thing to do is.
@bertjwregeer

This comment has been minimized.

Show comment
Hide comment
@bertjwregeer

bertjwregeer Jun 1, 2017

Member

Could you make sure to read and sign CONTRIBUTORS.txt please?

Member

bertjwregeer commented Jun 1, 2017

Could you make sure to read and sign CONTRIBUTORS.txt please?

@Flimm

This comment has been minimized.

Show comment
Hide comment
@Flimm

Flimm Jun 2, 2017

Contributor

Sorry, I didn't notice that file. I've added my name now. May I suggest creating a CONTRIBUTING or CONTRIBUTING.md file that instructs users to do this? GitHub will prominently display it when filing an issues or creating a pull request.

Contributor

Flimm commented Jun 2, 2017

Sorry, I didn't notice that file. I've added my name now. May I suggest creating a CONTRIBUTING or CONTRIBUTING.md file that instructs users to do this? GitHub will prominently display it when filing an issues or creating a pull request.

@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy

stevepiercy Jun 2, 2017

Member

@Flimm good suggestion. I created an issue #163.

Member

stevepiercy commented Jun 2, 2017

@Flimm good suggestion. I created an issue #163.

@gregsadetsky

This comment has been minimized.

Show comment
Hide comment
@gregsadetsky

gregsadetsky Aug 9, 2017

We can't wait for this to be merged and made available :-) Thank you @Flimm !

gregsadetsky commented Aug 9, 2017

We can't wait for this to be merged and made available :-) Thank you @Flimm !

@bertjwregeer

This comment has been minimized.

Show comment
Hide comment
@bertjwregeer

bertjwregeer Aug 9, 2017

Member

Sorry, I must have missed this PR being updated in the long list of work related PR's. Will check later tonight and most likely cut a new release!

Member

bertjwregeer commented Aug 9, 2017

Sorry, I must have missed this PR being updated in the long list of work related PR's. Will check later tonight and most likely cut a new release!

@gregsadetsky

This comment has been minimized.

Show comment
Hide comment
@gregsadetsky

gregsadetsky Aug 9, 2017

No worries! Thank you very very much @bertjwregeer !

gregsadetsky commented Aug 9, 2017

No worries! Thank you very very much @bertjwregeer !

@bertjwregeer bertjwregeer merged commit 87311e8 into Pylons:master Aug 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bertjwregeer

This comment has been minimized.

Show comment
Hide comment
@bertjwregeer

bertjwregeer Aug 16, 2017

Member

Thanks @Flimm!

@gregsadetsky thanks for commenting on this!

Member

bertjwregeer commented Aug 16, 2017

Thanks @Flimm!

@gregsadetsky thanks for commenting on this!

@pyup-bot pyup-bot referenced this pull request Nov 20, 2017

Open

Initial Update #31

@pyup-bot pyup-bot referenced this pull request Jan 26, 2018

Closed

Update waitress to 1.1.0 #406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment