Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translogger docs, reorganize, and clean up #206

Merged
merged 22 commits into from
Sep 23, 2018
Merged

Conversation

stevepiercy
Copy link
Member

See #70

@stevepiercy
Copy link
Member Author

I need some help fleshing out a section, per @mcdonc's comment.

@digitalresistor
Copy link
Member

I'd drop that section, the Paste Deploy section describes the config for logging, we can revisit at a later point in time if necessary.

@stevepiercy
Copy link
Member Author

Done in 6e35183, and opened #208

Waitress supports the `WSGI file_wrapper protocol
<http://www.python.org/dev/peps/pep-0333/#optional-platform-specific-file-handling>`_
. Here's a usage example:
Waitress supports the Python Web Server Gateway Interface v1.0 as specified in :pep:`333`. Here's a usage example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are changing this, change it to PEP 3333 please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cf5e04e

docs/glossary.rst Outdated Show resolved Hide resolved
docs/usage.rst Outdated

Press Ctrl-C (or Ctrl-Break on Windows) to exit the server.

The default is to bind to any IPv4 address on port 8080:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be moved up, and then we can remove this extra code block since it's the exact same example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made several other revisions while you were reviewing. Please check commit 88248b8, especially whether I got the bit about IPv4 or IPv6 addresses correct.

Add wasyncore entry.
Rewrap for clear, consistent indentation.
@stevepiercy
Copy link
Member Author

@bertjwregeer I'm done for now, except for how to handle wasyncore vs. asyncore throughout the docs.

@digitalresistor
Copy link
Member

Awesome Steve! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants