New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translogger docs, reorganize, and clean up #206

Merged
merged 22 commits into from Sep 23, 2018

Conversation

Projects
None yet
3 participants
@stevepiercy
Member

stevepiercy commented Sep 6, 2018

See #70

@stevepiercy stevepiercy requested a review from bertjwregeer Sep 6, 2018

@stevepiercy stevepiercy requested a review from mcdonc Sep 6, 2018

@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy
Member

stevepiercy commented Sep 6, 2018

I need some help fleshing out a section, per @mcdonc's comment.

@stevepiercy stevepiercy added the docs label Sep 6, 2018

@bertjwregeer

This comment has been minimized.

Show comment
Hide comment
@bertjwregeer

bertjwregeer Sep 6, 2018

Member

I'd drop that section, the Paste Deploy section describes the config for logging, we can revisit at a later point in time if necessary.

Member

bertjwregeer commented Sep 6, 2018

I'd drop that section, the Paste Deploy section describes the config for logging, we can revisit at a later point in time if necessary.

@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy

stevepiercy Sep 6, 2018

Member

Done in 6e35183, and opened #208

Member

stevepiercy commented Sep 6, 2018

Done in 6e35183, and opened #208

Show outdated Hide outdated docs/filewrapper.rst Outdated
Show resolved Hide resolved docs/glossary.rst Outdated
Show outdated Hide outdated docs/usage.rst Outdated

stevepiercy added some commits Sep 22, 2018

Make text align with its code.
Use consistent code-block indentation.
Use contextual versionadded directive.
Use proper casing for nginx.

stevepiercy added some commits Sep 22, 2018

Add versionchanged to asyncore entry.
Add wasyncore entry.
Rewrap for clear, consistent indentation.
@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy

stevepiercy Sep 22, 2018

Member

@bertjwregeer I'm done for now, except for how to handle wasyncore vs. asyncore throughout the docs.

Member

stevepiercy commented Sep 22, 2018

@bertjwregeer I'm done for now, except for how to handle wasyncore vs. asyncore throughout the docs.

@bertjwregeer

This comment has been minimized.

Show comment
Hide comment
@bertjwregeer

bertjwregeer Sep 23, 2018

Member

Awesome Steve! Thanks!

Member

bertjwregeer commented Sep 23, 2018

Awesome Steve! Thanks!

@bertjwregeer bertjwregeer merged commit 2f9b5b8 into master Sep 23, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bertjwregeer bertjwregeer deleted the doc_translogger branch Sep 23, 2018

@bertjwregeer bertjwregeer restored the doc_translogger branch Sep 23, 2018

@bertjwregeer bertjwregeer deleted the doc_translogger branch Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment