Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translogger docs, reorganize, and clean up #206

Merged
merged 22 commits into from Sep 23, 2018
Merged

Conversation

@stevepiercy
Copy link
Member

@stevepiercy stevepiercy commented Sep 6, 2018

See #70

@stevepiercy stevepiercy requested a review from bertjwregeer Sep 6, 2018
@stevepiercy stevepiercy requested a review from mcdonc Sep 6, 2018
@stevepiercy
Copy link
Member Author

@stevepiercy stevepiercy commented Sep 6, 2018

I need some help fleshing out a section, per @mcdonc's comment.

@stevepiercy stevepiercy added the docs label Sep 6, 2018
@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Sep 6, 2018

I'd drop that section, the Paste Deploy section describes the config for logging, we can revisit at a later point in time if necessary.

- See #208
@stevepiercy
Copy link
Member Author

@stevepiercy stevepiercy commented Sep 6, 2018

Done in 6e35183, and opened #208

Waitress supports the `WSGI file_wrapper protocol
<http://www.python.org/dev/peps/pep-0333/#optional-platform-specific-file-handling>`_
. Here's a usage example:
Waitress supports the Python Web Server Gateway Interface v1.0 as specified in :pep:`333`. Here's a usage example:

This comment has been minimized.

@bertjwregeer

bertjwregeer Sep 22, 2018
Member

Since you are changing this, change it to PEP 3333 please.

This comment has been minimized.

@stevepiercy

stevepiercy Sep 22, 2018
Author Member

Fixed in cf5e04e

docs/glossary.rst Outdated Show resolved Hide resolved
Press Ctrl-C (or Ctrl-Break on Windows) to exit the server.

The default is to bind to any IPv4 address on port 8080:

This comment has been minimized.

@bertjwregeer

bertjwregeer Sep 22, 2018
Member

This line can be moved up, and then we can remove this extra code block since it's the exact same example.

This comment has been minimized.

@stevepiercy

stevepiercy Sep 22, 2018
Author Member

I made several other revisions while you were reviewing. Please check commit 88248b8, especially whether I got the bit about IPv4 or IPv6 addresses correct.

stevepiercy added 5 commits Sep 22, 2018
Use consistent code-block indentation.
Use proper casing for nginx.
stevepiercy added 2 commits Sep 22, 2018
Add wasyncore entry.
Rewrap for clear, consistent indentation.
@stevepiercy
Copy link
Member Author

@stevepiercy stevepiercy commented Sep 22, 2018

@bertjwregeer I'm done for now, except for how to handle wasyncore vs. asyncore throughout the docs.

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Sep 23, 2018

Awesome Steve! Thanks!

@bertjwregeer bertjwregeer merged commit 2f9b5b8 into master Sep 23, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bertjwregeer bertjwregeer deleted the doc_translogger branch Sep 23, 2018
@bertjwregeer bertjwregeer restored the doc_translogger branch Sep 23, 2018
@bertjwregeer bertjwregeer deleted the doc_translogger branch Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.