-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translogger docs, reorganize, and clean up #206
Conversation
Import and change appropriately the pyramid docs regards paste.transl…
- strip .rst from toctree entries
I need some help fleshing out a section, per @mcdonc's comment. |
I'd drop that section, the Paste Deploy section describes the config for logging, we can revisit at a later point in time if necessary. |
docs/filewrapper.rst
Outdated
Waitress supports the `WSGI file_wrapper protocol | ||
<http://www.python.org/dev/peps/pep-0333/#optional-platform-specific-file-handling>`_ | ||
. Here's a usage example: | ||
Waitress supports the Python Web Server Gateway Interface v1.0 as specified in :pep:`333`. Here's a usage example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are changing this, change it to PEP 3333 please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in cf5e04e
docs/usage.rst
Outdated
|
||
Press Ctrl-C (or Ctrl-Break on Windows) to exit the server. | ||
|
||
The default is to bind to any IPv4 address on port 8080: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be moved up, and then we can remove this extra code block since it's the exact same example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made several other revisions while you were reviewing. Please check commit 88248b8, especially whether I got the bit about IPv4 or IPv6 addresses correct.
Use consistent code-block indentation.
Use proper casing for nginx.
Add wasyncore entry. Rewrap for clear, consistent indentation.
@bertjwregeer I'm done for now, except for how to handle |
Awesome Steve! Thanks! |
See #70