Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix error when HTTP version is missing in Python 3 #221
I encountered the following error in the log of our web server running waitress 1.1.0 on Python 3.6.1:
The problem comes from the variable
The suggested fix improves the Python 3 compatibility function to handle
It should instead be changed to ignore the request entirely/return an error to the requesting client. If crack first line is unable to figure out the HTTP version used, then it is not something that Waitress can properly deal with in the first place.
See #110 for a similar issue.
Instead of converting it to