Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve shutdown logic #245

merged 1 commit into from Apr 3, 2019

improve shutdown logic #245

merged 1 commit into from Apr 3, 2019


Copy link

This makes channel.cancel() set state to interrupt the app_iter. It also fixes an issue where the trigger may be closed before channel.service() is done executing, so we check self.connected there.

This should help get us closer to graceful shutdowns as well.

@digitalresistor digitalresistor marked this pull request as ready for review April 3, 2019 06:19
@digitalresistor digitalresistor merged commit ec29a08 into master Apr 3, 2019
@digitalresistor digitalresistor deleted the remove-dead-code branch April 3, 2019 06:23
mmerickel added a commit that referenced this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants