Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve shutdown logic #245

Merged
merged 1 commit into from Apr 3, 2019
Merged

improve shutdown logic #245

merged 1 commit into from Apr 3, 2019

Conversation

@mmerickel
Copy link
Member

@mmerickel mmerickel commented Apr 3, 2019

This makes channel.cancel() set state to interrupt the app_iter. It also fixes an issue where the trigger may be closed before channel.service() is done executing, so we check self.connected there.

This should help get us closer to graceful shutdowns as well.

@mmerickel mmerickel force-pushed the remove-dead-code branch from b8f7007 to bfb63ca Apr 3, 2019
@bertjwregeer bertjwregeer marked this pull request as ready for review Apr 3, 2019
@bertjwregeer bertjwregeer merged commit ec29a08 into master Apr 3, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bertjwregeer bertjwregeer deleted the remove-dead-code branch Apr 3, 2019
mmerickel added a commit that referenced this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants