Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush SO_SNDBUF data on every send and deprecate send_bytes #246

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@mmerickel
Copy link
Member

commented Apr 4, 2019

Fixes #120

Currently I deprecated send_bytes and it only affects the decision to flush but not how much to flush. Alternative options include:

  1. Remove the setting entirely and emit an error.

  2. Remove the setting but allow it and emit a UserWarning triggering people to remove it from their settings.

  3. Do not deprecate the setting and just define it as only affecting when to flush but not how much. Change the default to 1.

I propose keeping it like I did in the PR and then removing it in waitress 2.0 along with the trusted proxy backward-incompatible changes.

@bertjwregeer bertjwregeer merged commit b1b1d3e into master Apr 4, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bertjwregeer bertjwregeer deleted the so_sndbuf branch Apr 4, 2019

@ckcollab

This comment has been minimized.

Copy link

commented Apr 4, 2019

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.