Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid converting the version to a string value "None", empty instead #252

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
None yet
2 participants
@mmerickel
Copy link
Member

commented Apr 13, 2019

fixes #110
replaces #221

@bertjwregeer

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

I can understand the reasoning presented here, but I am not sure it is wise. I will however defer until later if this ends up blowing up for someone.

@bertjwregeer bertjwregeer merged commit 3c64da0 into master Apr 13, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bertjwregeer bertjwregeer deleted the crack-version branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.