Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: uri parsing #261

Merged
merged 4 commits into from Aug 27, 2019

Conversation

@bertjwregeer
Copy link
Member

commented Aug 27, 2019

Closes #260

Allow requests with URI that starts with multiple slashes
The HTTP spec states that it is acceptable to send a request like:

GET //whatever/testing HTTP/1.1

This should get properly conveyed to the WSGI application, but due to
the way that urlsplit works in the standard library this did not happen
correctly. With this fix we pass through the original path as requested
by the client, and the WSGI application will be responsible for
collapsing multiple empty path segments as necessary.

Fixes #260

@bertjwregeer bertjwregeer force-pushed the bugfix/uri_parsing branch from 5ca3c07 to 881fc2b Aug 27, 2019

@bertjwregeer bertjwregeer force-pushed the bugfix/uri_parsing branch from c850b95 to e9a2de7 Aug 27, 2019

@bertjwregeer bertjwregeer merged commit e247c93 into master Aug 27, 2019

2 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bertjwregeer bertjwregeer deleted the bugfix/uri_parsing branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.