Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize buffer behavior with multiple requests on the same connection #300

Merged
merged 2 commits into from May 20, 2020

Conversation

mmerickel
Copy link
Member

@mmerickel mmerickel commented May 20, 2020

previous to this change, a buffer may be reused across requests, and would not free its memory until it was full. We would prefer that only occur if a request is actually writing a large response, and across requests memory should be released. It also triggered a lot of unnecessary writing of data to disk on later requests since the outbuf-overflow would be reached on previous requests.

fixes #265

previous to this change, a buffer may be reused across requests, and
would cause data to be written to disk even if each individual request
was not returning much data

fixes #265
mmerickel added a commit that referenced this issue May 20, 2020
@bertjwregeer bertjwregeer merged commit 51f411a into master May 20, 2020
25 checks passed
@bertjwregeer bertjwregeer deleted the fix-265 branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants