stabilize buffer behavior with multiple requests on the same connection #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous to this change, a buffer may be reused across requests, and would cause data to be written to disk even if each individual request was not returning much data fixes #265
mmerickel
added a commit
that referenced
this pull request
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous to this change, a buffer may be reused across requests, and would not free its memory until it was full. We would prefer that only occur if a request is actually writing a large response, and across requests memory should be released. It also triggered a lot of unnecessary writing of data to disk on later requests since the outbuf-overflow would be reached on previous requests.
fixes #265