Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: thread name #302

Merged
merged 2 commits into from May 27, 2020
Merged

Fix: thread name #302

merged 2 commits into from May 27, 2020

Conversation

bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented May 27, 2020

Somewhere along the lines the thread name got set to just waitress rather than something that identifies thread number it is, this adds the thread number back to the name of the thread.

@bertjwregeer bertjwregeer marked this pull request as draft May 27, 2020
This way loggers that use the thread name display useful information
@bertjwregeer bertjwregeer marked this pull request as ready for review May 27, 2020
@bertjwregeer bertjwregeer requested a review from mmerickel May 27, 2020
@bertjwregeer
Copy link
Member Author

bertjwregeer commented May 27, 2020

@mmerickel I think that this change is uncontroversial, but would like your thoughts on it or if you feel strongly about it. I'd like to get this merged, get a new release out with those latest buffer changes, and then I am going to try and merge my Py3 only work into master.

@mmerickel mmerickel merged commit 1a4d1a9 into master May 27, 2020
25 checks passed
@mmerickel mmerickel deleted the fix/thread_name branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants