Bugfix: Don't close socket in the WSGI thread, delegate it back to the main thread! #377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There's a potential issue whereby a thread attempts to send data, but the socket is closed on the other end, and the thread shuts the socket down.
This may however happen while the file descriptors are being put together before being passed to
select()which will then fail as that file descriptor is no longer valid.Instead we loop until we have called
select()successfully, while checking to see if the file descriptors has changed since we started the poll.If the map of file descriptors has not changed, and yet we get an
errnothat is a bad file descriptor, we will just raise it and kill the main loop.Closes #374