Removed a warning that was displayed for HEAD requests. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Can I ask if this fix is part of a released version? I ran into it today. |
|
@merwok: seemingly not yet. It's still in the 'Next Release' section of the change log. |
|
0.8.3 just released with the fix. |
|
Thanks @mcdonc! |
|
✨ |
This was referenced Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept getting this warning when doing HEAD requests, but it seems normal to me to get no content in a head request. I made waitress check if the request is a HEAD before issuing the warning.
This patch comes with a test, and a little fix to the tests (first of the two commits).