Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring docs up-to-date with actual wsgify signature #167

Merged
merged 1 commit into from Apr 4, 2015

Conversation

@mmerickel
Copy link
Member

@mmerickel mmerickel commented Nov 5, 2014

the tests and code clearly expect (req, app, *_kw) and it makes sense that it
would be that way since req is the ephemeral argument and the rest are
defined at setup-time. The documented order before was (app, req, *_kw)
which puts the req in-between multiple config arguments in the
signature.

fixes #25, #120

the tests and code clearly expect (req, app, **kw) and it makes sense that it
would be that way since req is the ephemeral argument and the rest are
defined at setup-time. The documented order before was (app, req, **kw)
which puts the req in-between multiple config arguments in the
signature.

fixes #25, #120
@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Nov 10, 2014

👍 Looks good to me.

@bertjwregeer bertjwregeer added this to the Version 1.5 milestone Mar 23, 2015
@bertjwregeer bertjwregeer merged commit e4e8c47 into master Apr 4, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@bertjwregeer bertjwregeer deleted the fix.wsgify-middleware-docs branch Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.