request: read body from file if the method is PATCH #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis broken on Python 2.6. |
Currently Request.from_file ignore the body of a request if the method is PATCH. This fixes that by using the dictionary we have to know if a request might have a body or not.
jd
force-pushed
the
jd/read-body-on-patch
branch
from
2a9b542 to
b4ebafd
Compare
|
@tseaver Thanks, fixed. |
|
Ping ? |
|
@bertjwregeer LGTM. |
|
Thanks @tseaver. Pulled in. This will be in version 1.5. Hoping to get an alpha out the door by the end of PyCon. I will most likely back-port this to the 1.4 branch tonight. |
digitalresistor
added a commit
that referenced
this pull request
Apr 10, 2015
request: read body from file if the method is PATCH
digitalresistor
added a commit
that referenced
this pull request
Apr 11, 2015
request: read body from file if the method is PATCH
|
I've backported this to the 1.4 branch. Will get a new version out soon. |
openstack-gerrit
pushed a commit
to openstack-archive/gnocchi
that referenced
this pull request
Apr 15, 2015
webob had a bug wherein the body was not read on a PATCH. A pull
request was submitted:
Pylons/webob#184
and a new release with that change was released recently, breaking
fresh 'tox -e docs' jobs.
This changeset just requires the working WebOb. This may present
packaging issues, so tidier solutions welcome.
Closes-Bug: #1444160
Change-Id: I650a3ca3ae8381c556457c4504460c2b7f8a8d60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Request.from_file ignore the body of a request if the method
is PATCH. This fixes that by using the dictionary we have to know if a
request might have a body or not.
Same goes for as_bytes().