request: read body from file if the method is PATCH #184

Merged
merged 1 commit into from Apr 10, 2015

Projects

None yet

3 participants

@jd
Contributor
jd commented Dec 26, 2014

Currently Request.from_file ignore the body of a request if the method
is PATCH. This fixes that by using the dictionary we have to know if a
request might have a body or not.
Same goes for as_bytes().

@tseaver
Member
tseaver commented Dec 26, 2014

Travis broken on Python 2.6.

@jd jd request: read body from file if the method is PATCH
Currently Request.from_file ignore the body of a request if the method
is PATCH. This fixes that by using the dictionary we have to know if a
request might have a body or not.
b4ebafd
@jd
Contributor
jd commented Dec 26, 2014

@tseaver Thanks, fixed.

@jd
Contributor
jd commented Apr 10, 2015

Ping ?

@tseaver
Member
tseaver commented Apr 10, 2015
@bertjwregeer bertjwregeer added this to the Version 1.5 milestone Apr 10, 2015
@bertjwregeer
Member

Thanks @tseaver. Pulled in. This will be in version 1.5. Hoping to get an alpha out the door by the end of PyCon.

I will most likely back-port this to the 1.4 branch tonight.

@bertjwregeer bertjwregeer merged commit 0669e3f into Pylons:master Apr 10, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bertjwregeer
Member

I've backported this to the 1.4 branch. Will get a new version out soon.

@openstack-gerrit openstack-gerrit pushed a commit to openstack/gnocchi that referenced this pull request Apr 15, 2015
@cdent cdent Let WebOb read the body of a PATCH when creating docs
webob had a bug wherein the body was not read on a PATCH. A pull
request was submitted:

    Pylons/webob#184

and a new release with that change was released recently, breaking
fresh 'tox -e docs' jobs.

This changeset just requires the working WebOb. This may present
packaging issues, so tidier solutions welcome.

Closes-Bug: #1444160
Change-Id: I650a3ca3ae8381c556457c4504460c2b7f8a8d60
9dd0ebb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment