Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: read body from file if the method is PATCH #184

Merged
merged 1 commit into from Apr 10, 2015

Conversation

@jd
Copy link
Contributor

@jd jd commented Dec 26, 2014

Currently Request.from_file ignore the body of a request if the method
is PATCH. This fixes that by using the dictionary we have to know if a
request might have a body or not.
Same goes for as_bytes().

@tseaver
Copy link
Member

@tseaver tseaver commented Dec 26, 2014

Travis broken on Python 2.6.

Currently Request.from_file ignore the body of a request if the method
is PATCH. This fixes that by using the dictionary we have to know if a
request might have a body or not.
@jd jd force-pushed the jd:jd/read-body-on-patch branch from 2a9b542 to b4ebafd Dec 26, 2014
@jd
Copy link
Contributor Author

@jd jd commented Dec 26, 2014

@tseaver Thanks, fixed.

@jd
Copy link
Contributor Author

@jd jd commented Apr 10, 2015

Ping ?

@tseaver
Copy link
Member

@tseaver tseaver commented Apr 10, 2015

@bertjwregeer bertjwregeer added this to the Version 1.5 milestone Apr 10, 2015
@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Apr 10, 2015

Thanks @tseaver. Pulled in. This will be in version 1.5. Hoping to get an alpha out the door by the end of PyCon.

I will most likely back-port this to the 1.4 branch tonight.

bertjwregeer added a commit that referenced this pull request Apr 10, 2015
request: read body from file if the method is PATCH
@bertjwregeer bertjwregeer merged commit 0669e3f into Pylons:master Apr 10, 2015
1 check passed
1 check passed
@blaflamme
continuous-integration/travis-ci The Travis CI build passed
Details
bertjwregeer added a commit that referenced this pull request Apr 11, 2015
request: read body from file if the method is PATCH
@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Apr 11, 2015

I've backported this to the 1.4 branch. Will get a new version out soon.

openstack-gerrit pushed a commit to openstack-archive/gnocchi that referenced this pull request Apr 15, 2015
webob had a bug wherein the body was not read on a PATCH. A pull
request was submitted:

    Pylons/webob#184

and a new release with that change was released recently, breaking
fresh 'tox -e docs' jobs.

This changeset just requires the working WebOb. This may present
packaging issues, so tidier solutions welcome.

Closes-Bug: #1444160
Change-Id: I650a3ca3ae8381c556457c4504460c2b7f8a8d60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants