New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add a charset if none is specified and the content-type is JSON. #197

Merged
merged 1 commit into from Jan 28, 2016

Conversation

Projects
None yet
3 participants
@quantum-omega
Copy link
Contributor

quantum-omega commented Apr 23, 2015

Fixes #196. If a charset is already specified in the content-type, I opted to leave it there. Else, no charset will be added to the content-type line when the the effective content-type is JSON.

I also reworked the content-type-checking condition make it more legible.

@bertjwregeer bertjwregeer added this to the Version 1.6 milestone Dec 29, 2015

@bertjwregeer bertjwregeer merged commit 986bc21 into Pylons:master Jan 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattdrayer

This comment has been minimized.

Copy link

mattdrayer commented Mar 24, 2016

@bertjwregeer -- this is a bit of a shot in the dark, I think, but I am wondering if you might be willing to add some context to an Open edX component PR related to this particular webob change.

@bertjwregeer

This comment has been minimized.

Copy link
Member

bertjwregeer commented Mar 24, 2016

@mattdrayer Yep, with pleasure. Will update whatsnew-1.6 to further clarify why we removed it.

@mattdrayer

This comment has been minimized.

Copy link

mattdrayer commented Mar 24, 2016

Awesome, thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment