New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the _lazified class out of the lazify function #284

Merged
merged 1 commit into from Sep 30, 2016

Conversation

Projects
None yet
2 participants
@bertjwregeer
Copy link
Member

bertjwregeer commented Sep 29, 2016

Capturing the function, and returning a new object from a class that is
defined within the capturing function seems to cause some sort of really
pathological behavior that causes lazify() to take up a bunch of CPU
time, especially when it is part of a hot code path.

Thanks to Martijn Faassen (@faassen) for reporting!

Closes #282

Move the _lazified class out of the lazify function
Capturing the function, and returning a new object from a class that is
defined within the capturing function seems to cause some sort of really
pathological behavior that causes lazify() to take up a bunch of CPU
time, especially when it is part of a hot code path.

Thanks to Martijn Faassen for reporting!

Closes #282

@bertjwregeer bertjwregeer added this to the 1.7.0 milestone Sep 29, 2016

@mmerickel
Copy link
Member

mmerickel left a comment

LGTM

@bertjwregeer bertjwregeer merged commit d902761 into master Sep 30, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

bertjwregeer added a commit that referenced this pull request Sep 30, 2016

@bertjwregeer bertjwregeer deleted the bugfix/exc_performance branch Nov 18, 2016

@pyup-bot pyup-bot referenced this pull request Nov 3, 2017

Closed

Update webob to 1.7.3 #434

@pyup-bot pyup-bot referenced this pull request Jan 26, 2018

Closed

Update webob to 1.7.4 #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment