Feature: default body encoding #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@mmerickel This one's for you! |
This is mainly used to allow users to continue using .text even with Content-Types that don't have a charset. Looking at you Pyramid...
digitalresistor
force-pushed
the
feature/default_body_encoding
branch
from
867c800 to
99c3e76
Compare
mmerickel
approved these changes
Sep 30, 2016
Member
mmerickel
left a comment
mmerickel
left a comment
There was a problem hiding this comment.
This is a good best-effort feature to keep the body accessible as text.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyramid uses
.textin it's renderers, however with the changes made to remove charset when there is no charset on the content-type, this meant that things would break.Instead add a new
default_body_encodingtoResponsethat may be used as the alternative to charset. This will allow.textto continue functioning.It's a small backwards incompatible change, but if you were relying on WebOb to complain about no charset being set when accessing
.textI'd love to have a word with you :-).Closes #271