Skip to content

Fixup: PATH_SAFE#291

Merged
digitalresistor merged 5 commits intomasterfrom
fixup/PATH_SAFE
Nov 16, 2016
Merged

Fixup: PATH_SAFE#291
digitalresistor merged 5 commits intomasterfrom
fixup/PATH_SAFE

Conversation

@digitalresistor
Copy link
Member

This fixes PATH_SAFE to include more of the safe characters from RFC3986.

Closes #290

@mmerickel
Copy link
Member

You left a few characters (like _) out according to Pylons/pyramid#2811. Any particular reason?

Remove PyPy3, it is no longer supported by pip
@digitalresistor
Copy link
Member Author

Yes:

urllib.parse.quote:

Replace special characters in string using the %xx escape. Letters, digits, and the characters '_.-' are never quoted.

https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote

@mmerickel
Copy link
Member

Great, thanks.

Copy link
Member

@mmerickel mmerickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one more test for a url containing these characters to ensure they are no longer quoted? The added test appears to just check if [] is still quoted. It looks like you could just add to the test_path_quoting test directly above.

@digitalresistor
Copy link
Member Author

Update the only existing test :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixup w.r.PATH_SAFE to match RFC3986

2 participants