New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup: PATH_SAFE #291
Fixup: PATH_SAFE #291
Conversation
You left a few characters (like |
Remove PyPy3, it is no longer supported by pip
8de545b
to
4990963
Compare
Yes:
https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote |
Great, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add one more test for a url containing these characters to ensure they are no longer quoted? The added test appears to just check if []
is still quoted. It looks like you could just add to the test_path_quoting
test directly above.
Update the only existing test :P |
33f01bb
to
98f63b9
Compare
This fixes PATH_SAFE to include more of the safe characters from RFC3986.
Closes #290