Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup: PATH_SAFE #291

Merged
merged 5 commits into from Nov 16, 2016
Merged

Fixup: PATH_SAFE #291

merged 5 commits into from Nov 16, 2016

Conversation

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Nov 16, 2016

This fixes PATH_SAFE to include more of the safe characters from RFC3986.

Closes #290

@mmerickel
Copy link
Member

@mmerickel mmerickel commented Nov 16, 2016

You left a few characters (like _) out according to Pylons/pyramid#2811. Any particular reason?

Remove PyPy3, it is no longer supported by pip
@bertjwregeer bertjwregeer force-pushed the fixup/PATH_SAFE branch from 8de545b to 4990963 Nov 16, 2016
@bertjwregeer
Copy link
Member Author

@bertjwregeer bertjwregeer commented Nov 16, 2016

Yes:

urllib.parse.quote:

Replace special characters in string using the %xx escape. Letters, digits, and the characters '_.-' are never quoted.

https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote

@mmerickel
Copy link
Member

@mmerickel mmerickel commented Nov 16, 2016

Great, thanks.

Copy link
Member

@mmerickel mmerickel left a comment

Can you add one more test for a url containing these characters to ensure they are no longer quoted? The added test appears to just check if [] is still quoted. It looks like you could just add to the test_path_quoting test directly above.

@bertjwregeer
Copy link
Member Author

@bertjwregeer bertjwregeer commented Nov 16, 2016

Update the only existing test :P

@bertjwregeer bertjwregeer force-pushed the fixup/PATH_SAFE branch from 33f01bb to 98f63b9 Nov 16, 2016
@bertjwregeer bertjwregeer merged commit 2f3fd2c into master Nov 16, 2016
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bertjwregeer bertjwregeer deleted the fixup/PATH_SAFE branch Nov 16, 2016
@bertjwregeer bertjwregeer added this to the 1.7.0 milestone Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants