Bugfix: ipv6 host support#332
Merged
Merged
Conversation
Closed
mmerickel
reviewed
Jun 30, 2017
Member
mmerickel
left a comment
mmerickel
left a comment
There was a problem hiding this comment.
Any concerns here about badly formatted headers? Even as simple as a host header with no port will split the IPv6 address when it shouldn't right now.
mmerickel
reviewed
Jun 30, 2017
| @@ -414,7 +414,7 @@ def host_port(self): | |||
| host = e.get('HTTP_HOST') | |||
| if host is not None: | |||
| if ':' in host: | |||
Member
There was a problem hiding this comment.
This check is not enough to determine to split it based on :. The IPv6 address may not have a port but still has : characters.
digitalresistor
force-pushed
the
bugfix/ipv6_host_support
branch
from
dd75551 to
6a6e174
Compare
Don't split on IPv6 address if no port
digitalresistor
force-pushed
the
bugfix/ipv6_host_support
branch
from
6a6e174 to
0aac1a0
Compare
mmerickel
approved these changes
Jun 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #331