request.POST now supports any requests with the appropriate Content-Type (#351)#352
Conversation
Cykooz
changed the title
request.POST now supports DELETE requests with the appropriate Content-Type (#351)
|
Instead of limiting it to just certain request methods, it may be better to just look for content-type if it is not a This way the WebDav request methods also just work. |
| """ | ||
| env = self.environ | ||
| if self.method not in ('POST', 'PUT', 'PATCH'): | ||
| if self.method not in ('POST', 'PUT', 'PATCH', 'DELETE'): |
There was a problem hiding this comment.
I would argue for removal of this entirely, so that it just works on all request methods, Webdav has a bunch of other request methods for example and it doesn't make sense if we disallow .POST on those.
As long as we keep the line on 766 we should be good to go.
There was a problem hiding this comment.
It is a cool idea. I will remove this condition.
Cykooz
changed the title
|
Ping-ping. What about merging this PR? |
|
I've been busy with work and the flu. I'm also traveling at the moment. I'll get this merged before I push the release for 1.8. |
|
Thank you! |
2 participants
Issue #351