Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMEAccept mimics old behaviour better #356

Merged
merged 2 commits into from Apr 10, 2018
Merged

Conversation

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Apr 10, 2018

This updates MIMEAccept to mimic old behaviour better so that downstream
projects are not as broken.

The goal is not to provide the exact same behaviour, and thus MIMEAccept
still uses the new Accept header parsing and matching, however it is
much closer to the old API because it no longer raises on an invalid
header vs what was shipped in WebOb 1.8.0.

This updates MIMEAccept to mimic old behaviour better so that downstream
projects are not as broken.

The goal is not to provide the exact same behaviour, and thus MIMEAccept
still uses the new Accept header parsing and matching, however it is
much closer to the old API because it no longer raises on an invalid
header vs what was shipped in WebOb 1.8.0.
@bertjwregeer bertjwregeer merged commit d3d5012 into master Apr 10, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bertjwregeer bertjwregeer deleted the mimeaccept-mimics-better branch Apr 10, 2018
bertjwregeer added a commit that referenced this pull request Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants