Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: non-bytes samesite #362

Merged
merged 4 commits into from Jun 6, 2018
Merged

Bugfix: non-bytes samesite #362

merged 4 commits into from Jun 6, 2018

Conversation

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Jun 3, 2018

Correctly coerce non-bytes to bytes when serializing SameSite so that it's use matches that of the other parameters allowed by Response.set_cookie and cookies.make_cookie.

Closes #361
Related #362

@bertjwregeer bertjwregeer merged commit 2e719a9 into master Jun 6, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bertjwregeer bertjwregeer deleted the bugfix/nonbytes-samesite branch Jun 6, 2018
bertjwregeer added a commit that referenced this pull request Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant