New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support a standard api for parsing media types #376

Merged
merged 10 commits into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@mmerickel
Copy link
Member

mmerickel commented Sep 13, 2018

No description provided.

@mmerickel mmerickel force-pushed the mmerickel:accept-parse-offer branch from a3a878c to d150f9f Sep 13, 2018

Show resolved Hide resolved src/webob/acceptparse.py

mmerickel added some commits Sep 26, 2018

@mmerickel mmerickel force-pushed the mmerickel:accept-parse-offer branch from 206b6c5 to 8e1cccb Sep 27, 2018

@mmerickel

This comment has been minimized.

Copy link
Member

mmerickel commented Oct 2, 2018

This is ready for review. I can remove the specificity stuff from AcceptOffer if desired... it's not used anywhere but isn't really hurting anything and the conceptual ordering is used in a lot of places. I chose to not add a separate PR for a bug fix with acceptable_offers where Accept: */* did not match a range-based offer.

mmerickel added some commits Oct 2, 2018

@stevepiercy
Copy link
Member

stevepiercy left a comment

LGTM.

Show resolved Hide resolved src/webob/acceptparse.py Outdated

mmerickel added some commits Oct 10, 2018

remove media range support for offers
see the multitude of reasons in
Pylons/pyramid#3326

the short answer is that they are fundamentally broken in that media
ranges cannot properly match against any accept header with q=0 content
@mmerickel

This comment has been minimized.

Copy link
Member

mmerickel commented Oct 10, 2018

This PR now incorporates #378 and removes media range support from parse_offer and subsequently acceptable_offers. I would recommend merging #378 first and then reviewing this PR afterward.

@bertjwregeer bertjwregeer merged commit 1fa8a4e into Pylons:master Oct 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

bertjwregeer added a commit that referenced this pull request Oct 15, 2018

Backport pull request #376
support a standard api for parsing media types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment