additional test for 100% coverage of pull request 85 #97

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

twillis commented Mar 19, 2013

No description provided.

tests/test_response.py
+ res.app_iter = io.BytesIO(DATA)
+ res.encode_content('gzip')
+ result = list(res.app_iter)
+ assert len(result) < DATA
@RishiRamraj

RishiRamraj Mar 19, 2013

Contributor

Is this what you're going for?

assert len(''.join(result)) < len(DATA)
@twillis

twillis Mar 19, 2013

Contributor

hahahahah, yes you are right. damn it all :P

Contributor

RishiRamraj commented Mar 20, 2013

+1 looking good!

I think you're still missing the len on data :)

assert len("".join(result)) < len(DATA)

i blame the time zone differences.

Owner

mcdonc commented Mar 23, 2013

Sorry I hate to ask, but can somebody open up a new pull request with only the bugfixes for #85 (this one seems to contain fixes for #96 and I merged those already).

Contributor

twillis commented Mar 23, 2013

yeah I'll do it sorry for the confusion

Contributor

twillis commented Mar 23, 2013

#98

Owner

tseaver commented Mar 29, 2013

Closed via #98

@tseaver tseaver closed this Mar 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment