Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage to linux/osx GitHub actions #1359

Merged
merged 15 commits into from Mar 26, 2020

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Mar 24, 2020

Fixes N/A

Summary/Motivation:

The introduction of coverage reports into Github Actions get us one step closer to removing other external dependencies.

Changes proposed in this PR:

  • Add coverage report uploads to Unix workflow

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt requested a review from jsiirola March 24, 2020 19:32
@mrmundt
Copy link
Contributor Author

mrmundt commented Mar 24, 2020

The Appveyor build is giving this message:

Cannot assign job to clouds/groups 'pro, pro-backup'. All clouds within the group are either failing, offline, busy or reached build minutes quota.

The failure isn't related to the PR.

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #1359 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
+ Coverage   71.37%   71.53%   +0.16%     
==========================================
  Files         542      542              
  Lines       83764    84309     +545     
==========================================
+ Hits        59783    60311     +528     
- Misses      23981    23998      +17     
Impacted Files Coverage Δ
pyomo/solvers/plugins/solvers/GAMS.py 77.92% <0.00%> (+0.59%) ⬆️
pyomo/solvers/plugins/solvers/IPOPT.py 93.57% <0.00%> (+2.75%) ⬆️
pyomo/core/base/block.py 89.74% <0.00%> (+3.17%) ⬆️
pyomo/contrib/pynumero/extensions/utils.py 74.07% <0.00%> (+3.70%) ⬆️
pyomo/scripting/pyomo_parser.py 75.40% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8178df...c3f62dd. Read the comment docs.

@jsiirola
Copy link
Member

@mrmundt: we are seeing problems uploading to codecov now:

ERROR: The coverage upload was rejected because the workflow run is either not in-progress or finished a while ago. Please make sure the workflow run is in-progress and is not stale for uploads to process correctly.

@mrmundt
Copy link
Contributor Author

mrmundt commented Mar 24, 2020

@mrmundt: we are seeing problems uploading to codecov now:

ERROR: The coverage upload was rejected because the workflow run is either not in-progress or finished a while ago. Please make sure the workflow run is in-progress and is not stale for uploads to process correctly.

And it's failing for OSX now. Sigh. Lovely. I'll see what's up.

@jsiirola
Copy link
Member

@mrmundt, @blnicho: I think I am done playing with this. linux/osx are now working and pushing coverage to codecov. I snuck in a few other changes (mostly renaming things to match the new Travis names). If you agree, then I think we can merge!

@mrmundt
Copy link
Contributor Author

mrmundt commented Mar 26, 2020

Looks good to me! Thanks for fiddling with it.

@jsiirola jsiirola changed the title Unix Test Coverage Add test coverage to linux/osx GitHub actions Mar 26, 2020
@jsiirola jsiirola merged commit 9e0e2c6 into Pyomo:master Mar 26, 2020
@mrmundt mrmundt deleted the unix_coverage branch March 27, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants