[Bug report] Crash after repair / repair glitch

[orgi]

Describe the bug
After a fight ("Huegelhoehlen"), I ended up with two broken magical throwing axe's (if that is the english translation).

Then I used a scroll (not a spell) to repair one of those. Game crashed . After the crash, using the backup save game, the axe was repaired but the scroll was not used :)

Same later on for reparing the 2nd axe.

Crash Stack Trace:

Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at Ambermoon.UI.Layout.GetItemSlotPosition(ItemSlot itemSlot)
   at Ambermoon.Game.<>c__DisplayClass553_0.<ApplySpellEffect>g__PlayItemMagicAnimation|1(Action animationFinishAction)
   at Ambermoon.Game.<>c__DisplayClass553_0.<ApplySpellEffect>b__5()
   at Ambermoon.Game.Cast(Action action, Action finishAction, Action failAction, Boolean checkFail)
   at Ambermoon.Game.<>c__DisplayClass553_0.<ApplySpellEffect>g__Cast|0(Action action, Action finishAction, Action failAction)
   at Ambermoon.Game.ApplySpellEffect(Spell spell, Character caster, ItemSlot itemSlot, Action finishAction, Boolean checkFail)
   at Ambermoon.Game.<>c__DisplayClass603_0.<UseSpell>g__TargetItemPicked|13(ItemGrid itemGrid, Int32 slotIndex, ItemSlot itemSlot)
   at Ambermoon.Game.FinishPickingTargetInventory(ItemGrid itemGrid, Int32 slotIndex, ItemSlot itemSlot)
   at Ambermoon.UI.Layout.<TargetInventoryPlayerSelected>g__FinishPickingTargetItem|258_0(ItemGrid itemGrid, Int32 slotIndex, ItemSlot itemSlot)
   at Ambermoon.UI.ItemGrid.Click(Position position, DraggedItem draggedItem, ItemAction& itemAction, MouseButtons mouseButtons, CursorType& cursorType, Action`1 dragHandler, KeyModifiers keyModifiers)
   at Ambermoon.UI.Layout.Click(Position position, MouseButtons buttons, CursorType& cursorType, UInt32 currentTicks, Boolean pickingNewLeader, Boolean pickingTargetPlayer, Boolean pickingTargetInventory, KeyModifiers keyModifiers)
   at Ambermoon.Game.OnMouseDown(Position position, MouseButtons buttons, KeyModifiers keyModifiers)
   at Ambermoon.GameWindow.Mouse_MouseDown(IMouse mouse, MouseButton button)
   at Silk.NET.Input.Internals.MouseImplementationBase.HandleMouseDown(IMouse mouse, MouseButton button)
   at Silk.NET.Input.Glfw.GlfwMouse.<Subscribe>b__36_2(WindowHandle* _, MouseButton btn, InputAction action, KeyModifiers mods)
   at Silk.NET.Input.Glfw.GlfwEvents.<.ctor>b__0_2(WindowHandle* a, MouseButton b, InputAction c, KeyModifiers d)
   at Silk.NET.GLFW.Glfw.PollEvents()
   at Silk.NET.Windowing.Internals.ViewImplementationBase.Silk.NET.Windowing.IView.DoEvents()
   at Silk.NET.Windowing.WindowExtensions.<>c__DisplayClass2_0.<Run>b__0()
   at Silk.NET.Windowing.Internals.ViewImplementationBase.Run(Action onFrame)
   at Silk.NET.Windowing.WindowExtensions.Run(IView view)
   at Ambermoon.GameWindow.Run(Configuration configuration)
   at Ambermoon.Program.Main()
Press return to exit

Desktop (please complete the following information):

• OS: Win11
• Version: 1.17

[Pyrdacor]

Thanks for reporting. I will have a look at this soon.

[orgi]

Just wanted to let you know: This issue seems to be easy to reproduce for me. Just happened for the 3rd time. Please let me know in case it makes sense that I provide the save game files.

[Pyrdacor]

As I can't reproduce it on my end the savegame would be helpful. Thanks!

[orgi]

In the attached savegames zip, please find savegame number 10, which was saved before the last occurrence and no 11 afterwards.

Hope that helps.

Savegames.zip

[Pyrdacor]

Do you have a savegame with a broken item? Both savegames have only non-broken items so I can't test the repair.

[orgi]

Unfortunately currently I don’t. However once one of the ace’s will break again, I’ll create one. Should not take long. Am 21.03.2023 um 09:28 schrieb Pyrdacor ***@***.***>:  Do you have a savegame with a broken item? Both savegames have only non-broken items so I can't test the repair. — Reply to this email directly, view it on GitHub<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPyrdacor%2FAmbermoon.net%2Fissues%2F349%23issuecomment-1477437835&data=05%7C01%7C%7Cff87a060af124ef5644608db29e6373d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638149840961749996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=niZmFZtNar1OXctvQVtd4vgS7J78GPRi5HJaQcZVSYo%3D&reserved=0>, or unsubscribe<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHCECCHM56KQZJ6HOMZLYDW5FRB3ANCNFSM6AAAAAAWABFRNE&data=05%7C01%7C%7Cff87a060af124ef5644608db29e6373d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638149840961749996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VOf%2BCZjM27sN5D0zCiz9bZgbq1EkasCalyztKadhUxA%3D&reserved=0>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[orgi]

The axe just broke again. Saved the game before repair. However on a different island. Also I now have 3 more repair scrolls. Could not reproduce.
Will load one of the old save games to try to reproduce.

[orgi]

Tried with the old save game. Not reproducible anymore. Maybe once I save the game WITH the broken axe this fixes the issue?

[Pyrdacor]

I found the issue. It's caused by scrolling the inventory. I will work on a fix now.

It only happens if you need to scroll to get to the the item to repair.

[Pyrdacor]

Should be fixed in 1.8.3