fix: bug with dock commands #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
What is the return of commands RoborockCommand.GET_WASH_TOWEL_MODE and RoborockCommand.GET_DUST_COLLECTION_MOD ? |
Collaborator
Author
|
A single object dict. {"mode": 0} or {"wash_mode": 0} Wasn't sure if it was worth creating a container for it |
Collaborator
|
I think we should, cuz dust_collection and washing_mode variables could be None |
Collaborator
Author
|
Okay sounds good - I can make that change in a bit. Let me see if the user has any more bugs or feedback and I'll group it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test and fix bugs with the docking commands.