Moved code mappings to api #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humbertogontijo
requested changes
Mar 1, 2023
roborock/containers.py
Outdated
|
|
||
| @property | ||
| def status(self) -> str: | ||
| return STATE_CODE_TO_STATUS.get(self.state, f"Unknown Status {self.state}") |
Collaborator
There was a problem hiding this comment.
I think this should be handled in another way. Returning a free text instead of the status itself looks bad. There are already attribute like state, error_code and the new ones you added handling the raw value
Collaborator
Author
There was a problem hiding this comment.
What would you prefer? returning the state_code like before and just handling the get on the frontend like before? Perfectly fine with whatever you would like to do, just let me know.
Collaborator
There was a problem hiding this comment.
Yes. Just returning str mapping or None as before, and let whoever is using the data deal with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting an integration approved in HA is complicated. The larger the PR, the less likely it will be to be reviewed at any time soon.
So I moved the code mappings to the api to decrease the file size of vacuum.py.
We don't have to do this if you are against this.
This is a breaking change for the hacs integration. unless I make the same changes over there.
Let me know your thoughts.