Skip to content

feat: add room mapping #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2023
Merged

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Apr 25, 2023

No description provided.

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 25, 2023

Fixed some lint but not all that is from the local client changes.

@humbertogontijo
Copy link
Collaborator

Do you know the meaning of the third item?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 25, 2023

Do you know the meaning of the third item?

Third item?

@humbertogontijo
Copy link
Collaborator

DEBUG:roborock.local_api:id=24684 Response from get_room_mapping: [[16, '2396684', 13], [17, '2396658', 7], [18, '2396663', 3], [19, '2396661', 15], [20, '2396667', 8], [21, '2396647', 2], [23, '2396669', 14], [24, '2396683', 7], [25, '2396665', 15]]

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 25, 2023

Weird...

[[16, '2537175'], [17, '2537176'], [18, '2537178'], [19, '2537174'], [20, '3009519'], [21, '2957102'], [22, '2537149'], [23, '2537147']]

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 25, 2023

Do both ids correspond to the segments for your rooms?

i.e. if you were to clean 15 and 19 would they clean the same area?

@humbertogontijo
Copy link
Collaborator

I just noticed that my command app_clean_segment is not working for prefix b"\x00\x00\x00\x67" but it works with b"\x00\x00\x00\x87"

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 25, 2023

I just noticed that my command app_clean_segment is not working for prefix b"\x00\x00\x00\x67" but it works with b"\x00\x00\x00\x87"

Ah I have not actually tried it- is that one I changed? I'm in mobile right now so I can't check git history/ check if it is the same for me

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 25, 2023

As a quick check it does not appear to be working with the current settings on my HA app by calling the service. So the prefix change sounds good

Co-authored-by: Humberto Gontijo <humberto.gontijo@clevertech.biz>
@humbertogontijo humbertogontijo merged commit aa3e6e4 into Python-roborock:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants