Skip to content

Conversation

@Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Apr 28, 2023

Thoughts on this approach?

We can expand it as we find device specific functionality. but the device object is always around so it is easy to access.

Alternatively we could do an enum but that felt like overkill for right now.

@humbertogontijo
Copy link
Collaborator

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 28, 2023

@Lash-L Lash-L closed this Apr 29, 2023
@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 29, 2023

@humbertogontijo Are you sold on our current StrEnum approach for our code enums?

Any objection to doing it similar to how it is done in the link above - regular enums that get turned into a dict? Esp cause we don't actually have real typing with these and we couldn't subclass them very well/ easily to describe all "FanCodeEnums" or something like that.

What do you think?

@humbertogontijo
Copy link
Collaborator

I'm not happy with current strenum for codes.
No objection

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 29, 2023

Unfortunately I couldn't figure out how to add a missing value by default - so I just did it in the ones where they weren't device specific/ I thought we may run into a missing error in the future, which is not ideal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants