Adding some basic pytest #7
Conversation
| # status = device.device_status | ||
| # assert status.name == |
There was a problem hiding this comment.
device_status is not actually correct. The parameters for it are completely different than what the api returns. I don't think it used anywhere, but I noticed it from the test so I figured I would share.
|
@humbertogontijo Let me know when you end up pushing the new version to pypi. Alternatively, let me know if you want my help automating it with ci/cd |
|
@humbertogontijo ill have some time to work on this today, do you think you'll have a chance to publish to pypi? |
|
@humbertogontijo Thanks for merging and pushing to pypi! I'm going to create the HA PRs shortly. Let me know if you have any questions. I marked you as a codeowner. feel free to email me conway220@gmail.com if you have any questions. |
|
Hey! Thank you for your effort. Thanks again for all your help |
|
Ah, send me the link for your PR to HA core when you have it please |
|
@humbertogontijo no worries, I completely get it. |
2 participants
Super basic test so far, but it is a basis to build on.
Also added ci pipeline so that when a PR gets made or code is pushed into dev it will run all of the test, to make sure there's never an error introduced like I did with the circular dependency.
I can also add a ci task to automatically release a new version on pypi on dev push if that is something you are interested in.
You will have to enable Actions on github if this is something you want
This also caught that Python 3.9 is not supported(which doesn't matter as HA only allows for 3.10 and above