From 73d194ab76e0755f30939aec78c3f03b5f94a295 Mon Sep 17 00:00:00 2001 From: Qi Li Date: Thu, 31 Aug 2017 05:05:28 -0400 Subject: [PATCH] v1 final after having to do a resubmit. Updated readme and corrected app strings --- README.md | 6 +++--- app/build.gradle | 2 +- app/src/main/res/values/strings.xml | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 9da3e93..3db1868 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ Goalie Goalie -Get support from friends to reach your goals. Create a goal, and then assign a friend be your referee. The referee will help keep you accountable, and they can also help you along the way by sending you reminders. For extra incentive to reach your goals, try wagering your reputation points on the outcome. +Get support from friends to reach your goals. Create a goal, and then assign a friend be your referee. The referee will keep you accountable, and they can also help you along the way by sending you reminders. For extra incentive to reach your goals, try wagering your reputation points on the outcome. ## How to contribute @@ -14,11 +14,11 @@ To contribute with a fix, patch, new feature, or other improvements, simply crea ## Code style and structure -Follow good programming practices and please maintain as much consistency with the rest of the project. Utilize good MVP architecture for all Activities and core Fragments (Dialogs are not held to this standard at this time). +Follow good programming practices and please maintain as much consistency with the rest of the project. Utilize MVP architecture for all Activities and core Fragments (Dialogs are not held to this standard at this time). ## Backend server -Backend server code is not open source at this time, so unit test will fail if you have don't a local server setup (will fix this problem soon). Once you submit a pull request, I'll run the test suites against my local server to make sure things are OK. If you have a feature you like to add that requires server integration, please mock the REST calls and the results you wish to get back, I'll implement the logic on the server once you make a pull request. +Backend server code is not open source at this time, so unit test will fail if you don't have a local server setup (will fix this problem soon). Once you submit a pull request, I'll run the test suites against my local server to make sure things are OK. If you have a feature you'd like to add that requires server integration, please mock the REST calls and the results that you wish to get back, I'll implement the logic on the server once you make a pull request. ## License diff --git a/app/build.gradle b/app/build.gradle index fa8bb44..f53bb19 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -7,7 +7,7 @@ android { applicationId "com.github.q115.goalie_android" minSdkVersion 19 targetSdkVersion 26 - versionCode 3 + versionCode 4 versionName "1.0" testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" } diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 09ed631..0c9134a 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -118,7 +118,7 @@ No title entered for this goal. Invalid start or end time for this goal. No referee set for this goal. - Wager amount is invalid. If you need more reputation points, you will gain 50 points when you become someone\'s referee. + Wager amount is invalid. If you need more reputation points, you can get them when you become someone\'s referee. Goalie Notification