Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated StandardParameter #1859

Merged
merged 10 commits into from Dec 4, 2019

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented Nov 29, 2019

  • changelog entry.

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #1859 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   70.37%   70.37%   +<.01%     
==========================================
  Files         152      152              
  Lines       18863    18859       -4     
==========================================
- Hits        13274    13272       -2     
+ Misses       5589     5587       -2

@astafan8 astafan8 added this to the v0.9.0 milestone Dec 2, 2019
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few places where this is mentioned that should be removed too.

docs\community\objects.rst
16:   -  **Parameter**: StandardParameter
72:``StandardParameter`` which links it to specific commands sent to a

qcodes\instrument\base.py
91:                out of any class. Default ``StandardParameter``.

docs\examples\driver_examples\Qcodes example with Ithaco.ipynb
266:    "from qcodes.instrument.parameter import Parameter, StandardParameter\n"
(base) PS C:\Users\jenielse\source\repos\Qcodes>

@astafan8 astafan8 force-pushed the astafan8-remove-standard-parameter branch from 107f179 to 600da13 Compare December 3, 2019 17:00
@astafan8
Copy link
Contributor Author

astafan8 commented Dec 3, 2019

@jenshnielsen great catch! did it now, also added changelog entry.

@jenshnielsen
Copy link
Collaborator

ripgrep is your friend :)

@astafan8
Copy link
Contributor Author

astafan8 commented Dec 3, 2019

thanks :) i usually use the find-everywhere thingy in pycharm, but this time thought doing a PR from github will work ok, i was wrong))

@jenshnielsen jenshnielsen merged commit 2bc40e8 into master Dec 4, 2019
@jenshnielsen jenshnielsen deleted the astafan8-remove-standard-parameter branch December 4, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants