New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated StandardParameter #1859
Conversation
astafan8
commented
Nov 29, 2019
•
edited
edited
- changelog entry.
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
==========================================
+ Coverage 70.37% 70.37% +<.01%
==========================================
Files 152 152
Lines 18863 18859 -4
==========================================
- Hits 13274 13272 -2
+ Misses 5589 5587 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few places where this is mentioned that should be removed too.
docs\community\objects.rst
16: - **Parameter**: StandardParameter
72:``StandardParameter`` which links it to specific commands sent to a
qcodes\instrument\base.py
91: out of any class. Default ``StandardParameter``.
docs\examples\driver_examples\Qcodes example with Ithaco.ipynb
266: "from qcodes.instrument.parameter import Parameter, StandardParameter\n"
(base) PS C:\Users\jenielse\source\repos\Qcodes>
107f179
to
600da13
Compare
@jenshnielsen great catch! did it now, also added changelog entry. |
ripgrep is your friend :) |
thanks :) i usually use the find-everywhere thingy in pycharm, but this time thought doing a PR from github will work ok, i was wrong)) |