Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing driver notebooks #1892

Merged
merged 6 commits into from Jan 21, 2020

Conversation

lakhotiaharshit
Copy link
Contributor

Additionally fixes a small issue with 15 min to qcodes.
Provides a link to qcodes contrib driver repo and suggest community to contribute driver there.
Add a note to IPinstrument that visainstrument is the promoted method

@astafan8
@GateBuilder

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1892 into master will increase coverage by 0.08%.
The diff coverage is 28%.

@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
+ Coverage    70.3%   70.39%   +0.08%     
==========================================
  Files         152      152              
  Lines       18816    18870      +54     
==========================================
+ Hits        13229    13283      +54     
  Misses       5587     5587

@astafan8 astafan8 added the docs Related to docs improvements label Jan 16, 2020
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

i fixed a few typos though

@astafan8 astafan8 merged commit 9f31c04 into microsoft:master Jan 21, 2020
@lakhotiaharshit lakhotiaharshit deleted the fix_15mintoqcodes branch January 22, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants