Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to QCoDeS Rohde Schwarz instrument drivers #1911

Merged

Conversation

GateBuilder
Copy link
Contributor

This PR proposes minor improvements to the following Rohde Schwarz drivers:

  • HMC804x
  • SGS100A
  • RTO1000
  • ZNB

@jenshnielsen

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #1911 into master will not change coverage.
The diff coverage is 81.25%.

@@           Coverage Diff           @@
##           master    #1911   +/-   ##
=======================================
  Coverage   70.33%   70.33%           
=======================================
  Files         153      153           
  Lines       18954    18954           
=======================================
  Hits        13331    13331           
  Misses       5623     5623

qcodes/instrument_drivers/rohde_schwarz/RTO1000.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/rohde_schwarz/RTO1000.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/rohde_schwarz/ZNB.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/rohde_schwarz/ZNB.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/rohde_schwarz/ZNB.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/rohde_schwarz/ZNB.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/rohde_schwarz/private/HMC804x.py Outdated Show resolved Hide resolved
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Found on thing only :)

qcodes/instrument_drivers/rohde_schwarz/RTO1000.py Outdated Show resolved Hide resolved
GateBuilder and others added 2 commits February 18, 2020 12:55
@jenshnielsen jenshnielsen merged commit 2a43ed4 into microsoft:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants