Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settable/gettable attribute to parameters #1976

Merged

Conversation

jenshnielsen
Copy link
Collaborator

This should enable any user to detect if a parameter can be get/set without having to use getattr/hasattr introspection on the parameter.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #1976 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
- Coverage   70.49%   70.43%   -0.07%     
==========================================
  Files         148      148              
  Lines       19291    19246      -45     
==========================================
- Hits        13599    13555      -44     
+ Misses       5692     5691       -1     

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! :) towards explicitness and pythonization of parameters ;)

qcodes/tests/test_parameter.py Outdated Show resolved Hide resolved
qcodes/tests/test_parameter.py Outdated Show resolved Hide resolved
qcodes/instrument/parameter.py Outdated Show resolved Hide resolved
qcodes/instrument/parameter.py Show resolved Hide resolved
@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Apr 16, 2020

blocked on #1957 for now

@jenshnielsen jenshnielsen merged commit 3938f0a into microsoft:master Apr 17, 2020
@jenshnielsen jenshnielsen deleted the settable_gettable_attribute branch April 21, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants