New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settable/gettable attribute to parameters #1976
Merged
jenshnielsen
merged 15 commits into
microsoft:master
from
jenshnielsen:settable_gettable_attribute
Apr 17, 2020
Merged
Add settable/gettable attribute to parameters #1976
jenshnielsen
merged 15 commits into
microsoft:master
from
jenshnielsen:settable_gettable_attribute
Apr 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
settable_gettable_attribute
branch
from
April 16, 2020 07:57
5ff05a8
to
25fd3f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
- Coverage 70.49% 70.43% -0.07%
==========================================
Files 148 148
Lines 19291 19246 -45
==========================================
- Hits 13599 13555 -44
+ Misses 5692 5691 -1 |
astafan8
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! :) towards explicitness and pythonization of parameters ;)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable any user to detect if a parameter can be get/set without having to use getattr/hasattr introspection on the parameter.