Use pytest fixtures for tmp dir creation in tests

[jenshnielsen]

This should prevent the unable to unlink tmpdir because pytest has a reference to it failures that we see from time to time. https://docs.pytest.org/en/latest/tmpdir.html#temporary-directories-and-files

There are 3 context managers that I have still not changed. These should probably eventually be rewritten as pytest fixtures.

The pytest fixtures will only create one tmp_path pr test so in tests that requires 2 distinct directories I have used the factory functions to generate another one

[astafan8]

There are 3 context managers that I have still not changed. These should probably eventually be rewritten as pytest fixtures.

in test_config.py? i just looked at them, i think that they can all be safely be rewritten with tmp_path. the more interesting one, config_file_context, that one seems to be a candidate for a "fixture factory" (if i remember correctly, pytest supports that)

[jenshnielsen]

There are 3 context managers that I have still not changed. These should probably eventually be rewritten as pytest fixtures.

in test_config.py? i just looked at them, i think that they can all be safely be rewritten with tmp_path. the more interesting one, config_file_context, that one seems to be a candidate for a "fixture factory" (if i remember correctly, pytest supports that)

Maybe but they all failed the first time round. I suggest doing them in a separarate pr since this one is working now

[codecov]

Codecov Report

Merging #1988 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1988   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files         148      148           
  Lines       19248    19248           
=======================================
  Hits        13588    13588           
  Misses       5660     5660