Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DelegateInstrument support for single parameters #3031

Merged
merged 15 commits into from May 21, 2021

Conversation

guenp
Copy link
Contributor

@guenp guenp commented May 19, 2021

Changes proposed in this pull request:

  • Support passing either a list of parameters or a single parameter as part of the parameters dict to the DelegateInstrument constructor.

@jenshnielsen

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #3031 (22abcfa) into master (2e451b8) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##           master    #3031   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files         213      213           
  Lines       28436    28442    +6     
=======================================
+ Hits        18635    18640    +5     
- Misses       9801     9802    +1     

Copy link
Contributor

@trevormorgan trevormorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable update to me.

@jenshnielsen
Copy link
Collaborator

@guenp thanks. I made a few tweaks in guenp#6 can you have a look?

@jenshnielsen jenshnielsen added this to the 0.26.0 milestone May 20, 2021
@jenshnielsen jenshnielsen merged commit 0ab8a58 into microsoft:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants