Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give threads time to start in tests #3167

Merged
merged 2 commits into from Jul 2, 2021

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jul 2, 2021

Trying to debug a failed test on the master branch. This will hopefully make sure that all threads have started before any of them end and therefor does end up with a reused id.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #3167 (341f22f) into master (6a9ce75) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3167   +/-   ##
=======================================
  Coverage   65.90%   65.91%           
=======================================
  Files         217      217           
  Lines       28896    28902    +6     
=======================================
+ Hits        19045    19051    +6     
  Misses       9851     9851           

@jenshnielsen jenshnielsen changed the title make sure that thread id is not none Give threads time to start in tests Jul 2, 2021
@jenshnielsen jenshnielsen merged commit 89f6020 into microsoft:master Jul 2, 2021
@jenshnielsen jenshnielsen deleted the thread_id_check branch July 2, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants