Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal function should print maximization #180

Closed
jxmorris12 opened this issue Jul 2, 2020 · 1 comment · Fixed by #202
Closed

Goal function should print maximization #180

jxmorris12 opened this issue Jul 2, 2020 · 1 comment · Fixed by #202
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jxmorris12
Copy link
Collaborator

the input reduction recipe prints the following:

Attack(
  (search_method): GreedyWordSwapWIR(
    (wir_method):  delete
  )
  (goal_function):  InputReduction(
    (target_num_words):  1
  )
  (transformation):  WordDeletion
  (constraints): 
    (0): RepeatModification
    (1): StopwordModification
  (is_black_box):  True
)

however, it should be clear from the print message that the InputReduction goal function is to be maximized (not achieved)

@jxmorris12 jxmorris12 added bug Something isn't working good first issue Good for newcomers labels Jul 2, 2020
@uvafan
Copy link
Collaborator

uvafan commented Jul 2, 2020

It should also not print target_num_words if it's maximizable, since it doesn't have any effect when it's maximizable.

@jxmorris12 jxmorris12 linked a pull request Jul 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants