[WIP] Create plan type views #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR creates a view per plan type for wastewater structures. The INSERT works identical to vw_qgep_wastewater_structure but adds symbol The update Upserts symbol and updates the elements from vw_qgep_wastewater_structure DELETE only deletes the symbol, leaving the base untouched.
embed logic in create_views and drop_views
|
@cymed Can you rename this [WIP] Create plan type views |
sjib
added
the
feature
|
@cymed Is this ready for 1.6.2? Do we need a delta? |
|
Imho it is smarter to close it and port it to tww. Shall I close it here? |
|
Yes, please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a view per plan type for wastewater structures.
The INSERT works identical to vw_qgep_wastewater_structure but adds a wastewater_structure_symbol.
The UPDATE updates the elements from vw_qgep_wastewater_structure and Upserts wastewater_structure_symbol.
DELETE only deletes the wastewater_structure_symbol, leaving the other elements untouched.