From 1af462d56a793cd0a2773cd7b36ad63fbcce4cce Mon Sep 17 00:00:00 2001 From: GeoJulien Date: Mon, 13 May 2024 20:41:57 +0200 Subject: [PATCH 1/2] update(packaging): set QGIS maximum version since OSGeo4W broke LTR Python version --- qgis_resource_sharing/metadata.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qgis_resource_sharing/metadata.txt b/qgis_resource_sharing/metadata.txt index 46216b2e..a182eb8f 100644 --- a/qgis_resource_sharing/metadata.txt +++ b/qgis_resource_sharing/metadata.txt @@ -16,7 +16,7 @@ tracker=https://github.com/QGIS-Contribution/QGIS-ResourceSharing/issues/ # versioning version=1.1.0-beta1 qgisMinimumVersion=3.22 -qgisMaximumVersion=3.99 +qgisMaximumVersion=3.34.5 experimental=True deprecated=False changelog= From 4bcc026408060485576d2c250cc78fd885e35bae Mon Sep 17 00:00:00 2001 From: GeoJulien Date: Mon, 13 May 2024 20:45:39 +0200 Subject: [PATCH 2/2] improve(tests): check QGIS versions Inspired by @ptitjano --- tests/unit/test_plg_metadata.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/unit/test_plg_metadata.py b/tests/unit/test_plg_metadata.py index 9224bfe1..70ba5016 100644 --- a/tests/unit/test_plg_metadata.py +++ b/tests/unit/test_plg_metadata.py @@ -57,6 +57,7 @@ def test_metadata_types(self): # misc self.assertLessEqual(len(__about__.__title_clean__), len(__about__.__title__)) + # QGIS versions # QGIS versions self.assertIsInstance( __about__.__plugin_md__.get("general").get("qgisminimumversion"), str @@ -66,10 +67,13 @@ def test_metadata_types(self): __about__.__plugin_md__.get("general").get("qgismaximumversion"), str ) - self.assertLessEqual( - float(__about__.__plugin_md__.get("general").get("qgisminimumversion")), - float(__about__.__plugin_md__.get("general").get("qgismaximumversion")), + min_version_parsed = parse( + __about__.__plugin_md__.get("general").get("qgisminimumversion") + ) + max_version_parsed = parse( + __about__.__plugin_md__.get("general").get("qgismaximumversion") ) + self.assertLessEqual(min_version_parsed, max_version_parsed) def test_required_metadata(self): """Test that the plugin __init__ will validate on plugins.qgis.org."""