-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare terminology files in JSON #42
Comments
Communication to @dclunie on Jul 28
|
Response from @dclunie Jul 31
|
Slicer terminology+colors for completeness: http://wiki.slicer.org/slicerWiki/index.php/Documentation/4.2/Extensions/Reporting |
Hi Andrey I would not mention CP 1258 (incorrectly typed as 1528), since this I would reference CIDs 7150 and 7151 in the standard instead perhaps: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_CID_7150.html (and if you want to describe the history, reference CP 1258 only in Also, you are using a non-standard representation of the code tuples, (T-D000A;SRT;Anatomical Structure) I suggest: (T-D000A,SRT,"Anatomical Structure") I have NOT checked all the entries in the LUT table to make sure David PS. Is there a reason this information is in the 4.2 documentation On 8/2/16 4:48 PM, Andrey Fedorov wrote:
|
Done, I updated the page
The master spreadsheet is here: https://goo.gl/vuANnw, but I don't know how it is related to the wiki page, if either one was updated later. I think I had a conversion script from csv to wiki, but I am not sure where.
No, I don't! I will reuse the version from the drive and see how it can be reconciled with the ClearCanvas terminology compendum, to put together colors.
This "table" migrated to the core Slicer application at some point. Slicer main application does not have versioned documentation of color tables at that level, or it is not maintained, not sure. Slicer documentation is imperfect, that is the reason I guess... |
Approach implemented: - "SegmentationCategoryTypeContext" defines the list of category/type/modifier combinations - SegmentationCategoryTypeModifier.json is the result of converting SegmentationCategoryTypeModifier.xml, taken from "AIM on ClearCanvas", into JSON using the supplied xml2json.py script, with a small extra edit to account for conversion inconsistency - SlicerGenericAnatomy.csv is the result of importing first sheet of this document https://goo.gl/vuANnw in CSV, with small extra edits to account for missing quotes (also fixed in the master google doc) - SegmentationCategoryTypeModifierRGB.json is the result of adding RGB to the ClearCanvas JSON category/type by matching with CSV using the supplied mergeJSONCodesWithCSVColors.py script In a similar fashion, more narrowly-defined contexts could be defined, with a smaller number of codes tailored to a specific application. This is work towards QIICR#42
@dclunie: After reconciling the "AIM on ClearCanvas" category/type/modifier compendum with the list of codes we put together for Slicer (at least, a version of it - https://goo.gl/vuANnw!), there are some codes that are present in the Slicer list, but not in the ClearCanvas list. Here is the complete list of 49 entries that were not matched (category/type/modifier code tuples):
Looking at some of the discrepancies, some of them are minor (e.g., Some discrepancies are more substantial. For example, "Blood" is in the "Body substance" category in the Slicer list, but in the "Tissue" category in the ClearCanvas list. Considering that Blood is in I do not think it is urgent to reconcile the two tables. The list of codes used by Slicer will be replaced with the JSON-based segmentation context lists provided by dcmqi. So I hope you don't spend too much time on this. I can spend a bit more time later to reconcile the two, and let you know about any detailed substantial differences. For now, we have a ClearCanvas category/type/modifier list with RGB colors assigned from the Slicer list, so we can follow the same pattern of "segmentation category type context" for QIICR use cases, and also use these JSON files to improve both the dcmqi/seg web application, and support of terminology+colors in Slicer. |
It probably makes sense to use JSON for all tasks.
The text was updated successfully, but these errors were encountered: